Add tails of logs of failed packages to github comments #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Running another large run with multiple architectures to confirm it works in this case too. Will report. |
|
Mic92
reviewed
May 9, 2025
|
|
OK the last comment - I'm pretty happy about how it looks like @Mic92 but if you have some suggestions we can adjust. Let me know. |
|
One idea is to clean up special escape characters that come from tty colors / formatting, but I think it's fine to improve it separately. |
Mic92
reviewed
May 14, 2025
ansi2txt is a tool i often use. It should also be possible to find some python package for this or write a bespoke routine. |
Might be overkill. A regex should be good enough. |
|
Will test it first before opening for review. |
Snippets will be hidden under dropdown sections so as not to clutter UI. Snippets are limited to 20 lines, and if too many logs are generated, the report is truncated so that it fits into a single github comment. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
|
I hacked the tool a bit so that it produces spurious lines in attached logs, to confirm that the too long a report is gracefully handled with a warning. The result in the next comment. |
|
|
Also note that there are no more color codes in |
|
It would make sense to fold the list of packages with logs per platform as well |
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
isn't this what we see above? Would merge this otherwise. |
|
each log is folded but not the list of logs, this report currently takes 2.5 of my screen heights |
|
|
One thing I don't like is that we duplicate packages - and now their log snippets - because each output gets its own entry. This is not a problem specific to this PR so I leave it out of scope, but it seems like a waste - and we get some snippets not included as a result of this waste. I don't know how easy it is to filter these out without losing important context though, yet. As a heuristic, we could remember all snippets we've seen before, and if one is found (for the same system) that is identical, then just skip it. But not sure if I don't miss some important corner cases where it would be not justified. |
|
What it would look like if we were to skip duplicate snippets:
|
This was referenced Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snippets will be hidden under dropdown sections so as not to clutter UI.
Snippets are limited to 20 lines, and if too many logs are generated,
the report is truncated so that it fits into a single github comment.
Related: #308