Skip to content

Conversation

@pbsds
Copy link
Contributor

@pbsds pbsds commented Mar 9, 2025

No description provided.

@pbsds
Copy link
Contributor Author

pbsds commented Mar 15, 2025

Any other inputs @Mic92? @GaetanLepage could you also have a look?

@GaetanLepage
Copy link
Collaborator

This looks like a very good idea!
Have you tested it?
I was wondering if the injection of substituters in the CLI arguments was working.
Shouldn't there be additional quotes around the list of substituters.

@pbsds
Copy link
Contributor Author

pbsds commented Mar 15, 2025

I've tested that --option substituters "" causes nix log to fail to retrieve the build log if it is not in the local store. subprocess.run does not go through any shell, so no additional escaping is needed. I've also been using this on my big-parallel builder when checking larger rebuilds

@Mic92 Mic92 merged commit 3770396 into Mic92:master Mar 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants