skip regular lightmap computations with Fullbright & Xray

[RacoonDog]

Type of change

• Bug fix
• New feature
• Optimization

Description

instead of overwriting the work done by LightmapTextureManager#update, simply skip the entire function call if applicable

also, replace the createRenderPass call with the more lightweight clearColorTexture call

Related issues

none

How Has This Been Tested?

works on my pc 👍

Checklist:

• My code follows the style guidelines of this project.
• I have added comments to my code in more complex areas.
• I have tested the code in both development and production environments.

[RacoonDog]

Before: https://spark.lucko.me/J8QffK89s1?hl=4094 (~0.20% of render thread)
After: https://spark.lucko.me/uuws554Bjx?hl=1385 (~0.07% of render thread)

[MineGame159]

The logic itself looks fine but you are injecting before the profiler push() call, calling pop() and then cancelling the injection

[RacoonDog]

The logic itself looks fine but you are injecting before the profiler push() call, calling pop() and then cancelling the injection

yeah that sounds right to me, i made the normal lightTex profiler location encompass the clearColorTexture() call

(i inject before the push() call, and i call pop() myself because i cancel the rest of the method)

[MineGame159]

The logic itself looks fine but you are injecting before the profiler push() call, calling pop() and then cancelling the injection

yeah that sounds right to me, i made the normal lightTex profiler location encompass the clearColorTexture call

What? The injection is called before the push() call, so your pop() call not only happens before push() but it never even gets to push() because the method is cancelled.

[RacoonDog]

update: i was the stupid one