Update main.rst #74
Closed
Update main.rst #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfidan
reviewed
Oct 7, 2024
Collaborator
wolfidan
left a comment
wolfidan
left a comment
There was a problem hiding this comment.
With s3copypath I included the bucket name in the url, I think we should harmonize this. Do you prefer to separate bucket and endpoint?
Collaborator
Author
|
I think is better to separate bucket from end point to minimize confusions but it is up to you. |
Collaborator
|
Closing this PR as it is being taken care by ab4f5eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.