multi: Add decred. #1279
Draft
multi: Add decred. #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is complete now. Still waiting for feedback. Thanks. |
JoeGruffins
force-pushed
the
adddecred
branch
from
267cf63 to
43eab5a
Compare
|
hey @JoeGruffins sorry I didn't see the PR. I don't provide feedback on altcoins. Test it yourself and make sure it works. |
|
@NicolasDorier Thanks for replying! Gives us hope. We are changing a few things that aren't decred specific to allow decred to work. Please make sure we are not breaking anything and using methods you approve of! For example, whenever we hash a script or pubkey we use blake256 rather than sha256. We are trying to change as little as possible ofc. |
|
Rebasing and squashing and adding more. Please have a brief look though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not complete but wanted to get feedback. Trying to add decred here with the intent of adding it to BTCpay Server. I appreciate any feedback and will do whatever it takes to get decred added. Thanks for your time.