Skip to content

Add uint256.ToSpanString() #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add uint256.ToSpanString() #1198

wants to merge 3 commits into from

Conversation

kiminuo
Copy link
Contributor

@kiminuo kiminuo commented Jan 9, 2024 •
edited
Loading 

cd NBitcoin/NBitcoin.Bench
dotnet run -c Release -f net6.0 -- --runtimes net6.0 --filter "*UInt256Bench.WriteTo*"
Method destinationSpan Mean Error StdDev
WriteToString ? 92.973 ns 1.8389 ns 3.7977 ns
WriteToSpanString Char[64] 59.165 ns 1.0388 ns 0.9209 ns

kiminuo
kiminuo commented Jan 9, 2024
View reviewed changes
NBitcoin.Tests/NBitcoin.Tests.csproj
<PackageReference Include="Microsoft.CSharp" Version="4.6.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
<PackageReference Include="xunit" Version="2.6.5" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To allow testing with spans.

kiminuo
kiminuo commented Jan 9, 2024
View reviewed changes
kiminuo referenced this pull request in turbolay/WalletWasabi Jan 9, 2024
Fix other warnings from Wallet.cs
885374f
@kiminuo kiminuo force-pushed the feature/2024-01-09-Add-uint256-ToSpanString branch from befb119 to ba3987c Compare January 9, 2024 11:14
@kiminuo kiminuo force-pushed the feature/2024-01-09-Add-uint256-ToSpanString branch from ba3987c to 532919d Compare January 9, 2024 11:31
@kiminuo kiminuo force-pushed the feature/2024-01-09-Add-uint256-ToSpanString branch from 0374d0b to ff16374 Compare January 9, 2024 12:22
@NicolasDorier NicolasDorier force-pushed the master branch 2 times, most recently from 725a14b to bbcaf18 Compare January 16, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kiminuo