Update tsconfig lib, module, and target options
#266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Jun 6, 2025
| "lib": ["ES2020"], | ||
| "module": "CommonJS", | ||
| "moduleResolution": "node", | ||
| "lib": ["ES2023"], |
There was a problem hiding this comment.
We can use a ECMAScript version here that's newer than the target, in which case TypeScript will transpile newer features if necessary.
Mrtenz
commented
Jun 6, 2025
Comment on lines
+7
to
+8
| "module": "Node16", | ||
| "moduleResolution": "Node16", |
There was a problem hiding this comment.
Setting these to Node16 is recommended by the TypeScript team, and also speeds up ts-bridge.
Mrtenz
commented
Jun 6, 2025
| "noEmit": true, | ||
| "noErrorTruncation": true, | ||
| "noUncheckedIndexedAccess": true, | ||
| "strict": true, | ||
| "target": "es2020" | ||
| "target": "ES2022" |
There was a problem hiding this comment.
Following MetaMask/metamask-extension#32529, our targeted browsers fully support ES2022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
lib,module,moduleResolution, andtargetoptions intsconfig.