Skip to content

Conversation

@hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Nov 11, 2025

Description

This PR validates geo restriction for add funds.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds an E2E test verifying geo-block modal appears when tapping Add funds in Predictions, with new page object and selector support.

  • E2E Tests:
    • Update e2e/specs/predict/predict-geo-restriction.spec.ts to add a case: tapping Add funds from the Predictions balance shows the geo-restriction (Unavailable) modal and returns to the balance card.
  • Page Object:
    • Add e2e/pages/Predict/PredictAddFunds.ts with tapAddFunds() to trigger the action via text-matched button.
  • Selectors:
    • Extend e2e/selectors/Predict/Predict.selectors.ts with PredictAddFundsSelectorsIDs.ADD_FUNDS (from enContent.predict.deposit.add_funds).

Written by Cursor Bugbot for commit d2f2b11. This will update automatically on new commits. Configure here.

@hjetpoluru hjetpoluru requested a review from a team as a code owner November 11, 2025 13:53
@hjetpoluru hjetpoluru added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 11, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Nov 11, 2025
await TabBarComponent.tapActions();
await WalletActionsBottomSheet.tapPredictButton();
await Assertions.expectElementToBeVisible(
PredictDetailsPage.balanceCard,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Semantic Error: Page Object Mismatch

The test uses PredictDetailsPage.balanceCard but navigates to the Predict market list view, not a market details page. After tapping the Predict button on line 135, the user is on the market list screen where the balance card is displayed. Using PredictDetailsPage.balanceCard is semantically incorrect since PredictDetailsPage represents a specific market's details page, not the market list view. While the selector may work if both pages use the same test ID, it creates confusion and could break if the pages are refactored separately.

Fix in Cursor Fix in Web

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.92%. Comparing base (dddee92) to head (d2f2b11).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22490      +/-   ##
==========================================
+ Coverage   77.86%   77.92%   +0.06%     
==========================================
  Files        3826     3835       +9     
  Lines       98105    98066      -39     
  Branches    19236    19262      +26     
==========================================
+ Hits        76389    76422      +33     
+ Misses      16480    16400      -80     
- Partials     5236     5244       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants