-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: Check geo restriction for add funds #22490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| await TabBarComponent.tapActions(); | ||
| await WalletActionsBottomSheet.tapPredictButton(); | ||
| await Assertions.expectElementToBeVisible( | ||
| PredictDetailsPage.balanceCard, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Semantic Error: Page Object Mismatch
The test uses PredictDetailsPage.balanceCard but navigates to the Predict market list view, not a market details page. After tapping the Predict button on line 135, the user is on the market list screen where the balance card is displayed. Using PredictDetailsPage.balanceCard is semantically incorrect since PredictDetailsPage represents a specific market's details page, not the market list view. While the selector may work if both pages use the same test ID, it creates confusion and could break if the pages are refactored separately.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22490 +/- ##
==========================================
+ Coverage 77.86% 77.92% +0.06%
==========================================
Files 3826 3835 +9
Lines 98105 98066 -39
Branches 19236 19262 +26
==========================================
+ Hits 76389 76422 +33
+ Misses 16480 16400 -80
- Partials 5236 5244 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Description
This PR validates geo restriction for add funds.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds an E2E test verifying geo-block modal appears when tapping Add funds in Predictions, with new page object and selector support.
e2e/specs/predict/predict-geo-restriction.spec.tsto add a case: tappingAdd fundsfrom the Predictions balance shows the geo-restriction (Unavailable) modal and returns to the balance card.e2e/pages/Predict/PredictAddFunds.tswithtapAddFunds()to trigger the action via text-matched button.e2e/selectors/Predict/Predict.selectors.tswithPredictAddFundsSelectorsIDs.ADD_FUNDS(fromenContent.predict.deposit.add_funds).Written by Cursor Bugbot for commit d2f2b11. This will update automatically on new commits. Configure here.