Skip to content

fix(perps): enable live PnL in perps position card #22487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix(perps): enable live PnL in perps position card #22487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/components/UI/Perps/components/PerpsMarketTabs/PerpsMarketTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,10 @@ const PerpsMarketTabs: React.FC<PerpsMarketTabsProps> = ({
);

// Subscribe to data internally (marketStats moved to StatisticsTabContent to isolate price updates)
const { positions } = usePerpsLivePositions({ throttleMs: 0 });
const { positions } = usePerpsLivePositions({
throttleMs: 0,
useLivePnl: true,
});
Copy link

@cursor cursor bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unthrottled Live PnL impacts performance.

Enabling useLivePnl: true with throttleMs: 0 causes the component to re-render on every WebSocket price tick, potentially degrading performance. Other components using live PnL (like PerpsPositionsView) throttle updates to 1000ms. Consider adding throttling to balance real-time updates with performance, especially since the component already uses memoization to isolate price updates in StatisticsTabContent.

Fix in Cursor Fix in Web

const { orders: allOrders } = usePerpsLiveOrders({ throttleMs: 0 });

const position = useMemo(
Expand Down
Loading