Skip to content

Conversation

@witmicko
Copy link
Contributor

@witmicko witmicko commented Nov 10, 2025

Description

Updating code scanner to v2

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Migrates the security scanning workflow to the v2 reusable action with updated inputs/secrets and broader PR trigger.

  • CI (GitHub Actions):
    • Security Scanner Migration: Replace step-based scanner with reusable workflow MetaMask/action-security-code-scanner/.github/workflows/security-scan.yml@v2.
      • Add with inputs: repo, scanner-ref: v2, and paths-ignored (preserves previous ignore list).
      • Map secrets via secrets (project-metrics-token, slack-webhook).
      • Remove explicit runs-on and custom step; rely on reusable workflow.
    • Triggers: Keep push to main; allow pull_request on all branches (removed branch filter); retain workflow_dispatch.
    • Permissions: Keep actions, contents, and security-events permissions.

Written by Cursor Bugbot for commit 634c73a. This will update automatically on new commits. Configure here.

@witmicko witmicko added the team-application-security Application security team label Nov 10, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@witmicko witmicko marked this pull request as draft November 10, 2025 18:22
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-application-security Application security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants