Skip to content

Conversation

@christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 commented Nov 10, 2025

Description

This PR fixes the Android local builds as currently they're building in CI release mode which is incompatible with local runs.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Require both METAMASK_ENVIRONMENT=e2e and E2E=true for Android E2E builds; bump build numbers to 2993 across Android, iOS, and Bitrise.

  • Build scripts:
    • Android scripts/build.sh: E2E build paths now require both METAMASK_ENVIRONMENT='e2e' AND E2E='true' for main and flask targets (was OR).
  • Versioning:
    • Android android/app/build.gradle: bump versionCode to 2993.
    • iOS ios/MetaMask.xcodeproj/project.pbxproj: bump CURRENT_PROJECT_VERSION to 2993 across all targets/configs.
    • CI bitrise.yml: update VERSION_NUMBER and FLASK_VERSION_NUMBER to 2993.

Written by Cursor Bugbot for commit 09afc2b. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner November 10, 2025 15:31
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 10, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Nov 10, 2025
@christopherferreira9 christopherferreira9 added run-android-flask-e2e-smoke Run Android flask E2E tests on next CI run team-qa QA team and removed team-qa QA team labels Nov 10, 2025
@sonarqubecloud
Copy link

tommasini
tommasini previously approved these changes Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed run-android-flask-e2e-smoke Run Android flask E2E tests on next CI run size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants