Skip to content

feat: Network Manager UI #16642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

feat: Network Manager UI #16642

wants to merge 31 commits into from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Jun 24, 2025

Description

Network Enablement UI integration

Replaces the legacy network filter with the new Network Manager, allowing users to control which networks are enabled in MetaMask. Enabled networks determine asset visibility and dapp connectivity.
Key features:

  • Users can add and enable networks through the Network Manager
  • Custom Networks and Solana show assets only for the selected network
  • Default networks (Ethereum, Arbitrum) display assets across all enabled networks
  • Dapp network requests automatically switch to and enable the requested network
  • New network additions via dapp connections are auto-enabled

Related issues

Fixes: 5083

Manual testing steps

  1. Run application with MM_REMOVE_GLOBAL_NETWORK_SELECTOR='true' to see how this feature interacts with the other GNS removal features.
  2. The @metamask/network-enablement-controller hasn't been published yet. Here is the PR. Because of this you must build the package locally. Pull down core and checkout into the branch chore/network-enablement-controller and run yarn build
  3. Run yarn && yarn watch:clean
  4. Create a new wallet, or import a new wallet
  5. Network filter will initially set to one network, select it to enable networks
  6. Enabling Custom networks will remove all other selections
  7. Enabling a Default network will multiselect/deselect default networks
  8. ☝️ Exception here is Solana. Solana is disabled

Screenshots/Recordings

Update so far:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-25.at.17.55.03.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward changed the title feat: network filter feat: Network Manager UI Jun 25, 2025
Copy link

socket-security bot commented Jun 30, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​metamask/​network-enablement-controller@​0.0.0100100100100100

View full report

@vinnyhoward vinnyhoward added the Run Smoke E2E Requires smoke E2E testing label Jul 16, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 16, 2025
Copy link
Contributor

github-actions bot commented Jul 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dc2c2fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1183441-18a2-42f8-a75b-88174f28b21c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward force-pushed the feat-5083-asset-filter-ui branch from d443c95 to a5328af Compare July 16, 2025 21:44
@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 16, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 16, 2025
Copy link
Contributor

github-actions bot commented Jul 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 17064b5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddb60967-2f64-4375-b9ff-cdf825ce0bae

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 17, 2025
Copy link
Contributor

github-actions bot commented Jul 17, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2e35e04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d9a20c7-ec42-4ccc-8bde-d11d92e16016

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 17, 2025
Copy link
Contributor

github-actions bot commented Jul 17, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9e9a636
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ead4f7d6-e99a-44d9-8448-b53f1f5aad61

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Requires smoke E2E testing team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants