Skip to content

chore: Remove ios simulator runway bucket link #14896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Apr 25, 2025

Description

We are hiding the iOS simulator Runway bucket link for now since the bucket doesn't expose additional artifact files. That is where the zipped .app files live. We've reached out to the Runway team requesting this feature here - https://consensys.slack.com/archives/C06J3Q52MMY/p1745453655180929?thread_ts=1744297584.706479&cid=C06J3Q52MMY. As a follow up, we are exploring hosting a GH page to track prebuilds in the meantime - https://github.com/MetaMask/metamask-mobile-prebuilds

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 25, 2025
@Cal-L Cal-L changed the title chore: Remove ios simulator runway bucket chore: Remove ios simulator runway bucket link Apr 25, 2025
@Cal-L Cal-L added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed No E2E Smoke Needed If the PR does not need E2E smoke test run needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 25, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Apr 25, 2025
@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 25, 2025
@Cal-L Cal-L enabled auto-merge April 25, 2025 19:45
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-mobile-platform Mobile Platform team
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

3 participants