Skip to content

fix: cp-7.46.0 add percent change for asset list v2 #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sahar-fehri
Copy link
Contributor

Description

Adds asset list 24h price change

Related issues

Fixes:

Manual testing steps

  1. Switch to a Solana account
  2. You should be able to see the 24h percent change on the asset list and aggregated balance

Screenshots/Recordings

Before

After

Screenshot 2025-04-24 at 15 44 55

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested review from a team as code owners April 25, 2025 13:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a3d7240
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2ce6454-1e44-40ea-a5ec-0f469da579f5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri changed the title Fix/add percent change for asset list v2 feat: add percent change for asset list v2 Apr 25, 2025
@sahar-fehri sahar-fehri changed the title feat: add percent change for asset list v2 fix: cp-7.46.0 add percent change for asset list v2 Apr 25, 2025
@sahar-fehri sahar-fehri added no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 25, 2025
Comment on lines 182 to 184
pricePercentChange1d =
allMultichainAssetsRates[asset?.address as CaipAssetType]?.marketData
?.pricePercentChange?.P1D;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the above variable is codefenced, should this also be code-fenced?

Copy link
Contributor

@gambinish gambinish Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume we'd at least need a !isEvmNetwork check. Since Bitrise is passing, I guess this is actually fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm interesting!
I all for ditching codefences (they are so painful to debug lol)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this is working as is. Given that the allMultichainAssetsRates is behind a code fence, this variable would not exist on a main build and should throw an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored here 08e6bd6

gambinish
gambinish previously approved these changes Apr 25, 2025
salimtb
salimtb previously approved these changes Apr 25, 2025
@sahar-fehri sahar-fehri dismissed stale reviews from gambinish and Prithpal-Sooriya via 02bd9fe April 25, 2025 20:24
@sahar-fehri sahar-fehri force-pushed the fix/add-percent-change-for-asset-list-v2 branch from b499a35 to 984beec Compare April 26, 2025 00:36
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 26, 2025
Copy link
Contributor

github-actions bot commented Apr 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 984beec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b4fc845-dfe7-4b44-87e2-8edb84300447

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 26, 2025
@sahar-fehri sahar-fehri force-pushed the fix/add-percent-change-for-asset-list-v2 branch from ad05484 to ac59af1 Compare April 26, 2025 22:34
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 26, 2025
Copy link
Contributor

github-actions bot commented Apr 26, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ac59af1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ebb11f88-0b6c-483c-a70c-31564a230f48

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri force-pushed the fix/add-percent-change-for-asset-list-v2 branch from ac59af1 to 08e6bd6 Compare April 26, 2025 23:22
@sahar-fehri sahar-fehri added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 26, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (944fce2) to head (08e6bd6).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...ggregatedPercentage/NonEvmAggregatedPercentage.tsx 75.00% 3 Missing and 7 partials ⚠️
...onents/UI/Tokens/TokenList/TokenListItem/index.tsx 57.14% 1 Missing and 2 partials ⚠️
...nts/UI/Tokens/TokenList/PortfolioBalance/index.tsx 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14892      +/-   ##
==========================================
+ Coverage   67.71%   67.84%   +0.12%     
==========================================
  Files        2329     2343      +14     
  Lines       50144    50443     +299     
  Branches     7373     7444      +71     
==========================================
+ Hits        33954    34221     +267     
- Misses      14054    14060       +6     
- Partials     2136     2162      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants