Skip to content

feat: solana banner cp-7.46.0 #14881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: solana banner cp-7.46.0 #14881

wants to merge 6 commits into from
+581 −8

Conversation

aganglada
Copy link
Contributor

Description

  • Adds solana feature
  • Adds solana banner for promotion
  • Only appears when you are on on a solana account
  • When you click on it, if you don't have a solana account, it prompts you to create one
  • When you click on it, if you have a solana account, it move you to the last selected
  • Adds tracking for the two cases above

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 16 Pro - 2025-04-25 at 10 17 13

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@aganglada aganglada self-assigned this Apr 25, 2025
@aganglada aganglada requested review from a team as code owners April 25, 2025 08:21
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@aganglada aganglada added No E2E Smoke Needed If the PR does not need E2E smoke test run QA Passed A successful QA run through has been done labels Apr 25, 2025
@tommasini
Copy link
Contributor

Can we increase the unit test coverage? Also I think it would be good to run the e2e as well on this PR

@aganglada aganglada added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Apr 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 16c67cf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbfc49db-abc1-481e-a551-b70295fd5736

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@aganglada aganglada added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 25, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommasini tommasini tommasini left review comments

@xavier-brochard xavier-brochard xavier-brochard approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@aganglada aganglada

Labels
QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise team-solana
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aganglada @tommasini @xavier-brochard @metamaskbot