Create shield controller #6137
Draft
Create shield controller #6137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwin-kyaw
reviewed
Jul 21, 2025
| /** | ||
| * The internal actions available to the ShieldController. | ||
| */ | ||
| export type ShieldControllerActions = ShieldControllerCheckCoverageAction; |
There was a problem hiding this comment.
Would be nice if we put all the types in separate file, e.g. types.ts
lwin-kyaw
reviewed
Jul 21, 2025
| @@ -20,8 +20,6 @@ export default async function cli( | |||
| // Disable --version. This is an internal tool and it doesn't have a version. | |||
| .version(false) | |||
| .usage('$0 [args]') | |||
| // @ts-expect-error: The CommandModule<T, U>[] signature does in fact exist, | |||
There was a problem hiding this comment.
May I know why do we need to update this?
If it's not working, I think we should do it in separate PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
New controller for MetaMask Shield.
References
Changelog
Checklist