Skip to content

chore: clean-up Multichain API errors #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wenfix
Copy link
Contributor

@wenfix wenfix commented Jul 14, 2025

Explanation

Currently, on Multichain API handlers (@metamask/multichain-api-middleware), we're throwing a JSON-RPC Internal Error (-32603) instead of CAIP-25 5000. We're also inling errors instead of using those defined in Caip25Errors. This PR adds missing errors and updates usage across handlers.

References

Fixes https://github.com/MetaMask/MetaMask-planning/issues/5251

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@wenfix wenfix requested a review from a team as a code owner July 14, 2025 15:06
@wenfix wenfix requested a review from a team as a code owner July 14, 2025 15:19
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant