fix: handle snaps error

[salimtb]

Explanation

The MultichainAssetsRatesController was experiencing crashes when Snap requests failed due to parameter validation errors.

the error handling was insufficient - when Snap requests failed, the controller will send a sentry error rather than gracefully handling the error and continuing operation.

References

Changelog

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[cursor]

Bug: Snap Request Handling Bypass Causes Errors

The fetchHistoricalPricesForAsset method bypasses the new #handleSnapRequest method, directly calling messagingSystem.call. This prevents graceful error handling (logging and returning undefined) for historical price requests, unlike other snap requests, potentially causing crashes and contradicting the PR's goal of improved error handling for all snap requests.

packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts#L424-L440

core/packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts

Lines 424 to 440 in 1e2009d

	try {
	const historicalPricesResponse = await this.messagingSystem.call(
	'SnapController:handleRequest',
	{
	snapId: selectedAccount?.metadata.snap?.id as SnapId,
	origin: 'metamask',
	handler: HandlerType.OnAssetHistoricalPrice,
	request: {
	jsonrpc: '2.0',
	method: HandlerType.OnAssetHistoricalPrice,
	params: {
	from: asset,
	to: currentCaipCurrency,
	},
	},
	},
	);

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎