Skip to content

Normalizes fourByte data in method selector #6102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2025

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jul 10, 2025

Explanation

This PR updates the getMethodName utility to normalise the transaction data to lowercase before comparing it against known ABI method selectors.

References

Fixes https://github.com/MetaMask/MetaMask-planning/issues/5338

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@vinistevam vinistevam marked this pull request as ready for review July 10, 2025 16:11
@vinistevam vinistevam requested review from a team as code owners July 10, 2025 16:11
Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a sanity check - have we tested locally with given scenario to be sure fix working properly?

@vinistevam
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "0.5.0-preview-04ab3e60",
  "@metamask-previews/accounts-controller": "31.0.0-preview-04ab3e60",
  "@metamask-previews/address-book-controller": "6.1.1-preview-04ab3e60",
  "@metamask-previews/announcement-controller": "7.0.3-preview-04ab3e60",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-04ab3e60",
  "@metamask-previews/approval-controller": "7.1.3-preview-04ab3e60",
  "@metamask-previews/assets-controllers": "72.0.0-preview-04ab3e60",
  "@metamask-previews/base-controller": "8.0.1-preview-04ab3e60",
  "@metamask-previews/bridge-controller": "36.1.0-preview-04ab3e60",
  "@metamask-previews/bridge-status-controller": "36.0.0-preview-04ab3e60",
  "@metamask-previews/build-utils": "3.0.3-preview-04ab3e60",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-04ab3e60",
  "@metamask-previews/composable-controller": "11.0.0-preview-04ab3e60",
  "@metamask-previews/controller-utils": "11.11.0-preview-04ab3e60",
  "@metamask-previews/delegation-controller": "0.5.0-preview-04ab3e60",
  "@metamask-previews/earn-controller": "3.0.0-preview-04ab3e60",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-04ab3e60",
  "@metamask-previews/ens-controller": "17.0.1-preview-04ab3e60",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-04ab3e60",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-04ab3e60",
  "@metamask-previews/foundryup": "1.0.0-preview-04ab3e60",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-04ab3e60",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-04ab3e60",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-04ab3e60",
  "@metamask-previews/keyring-controller": "22.1.0-preview-04ab3e60",
  "@metamask-previews/logging-controller": "6.0.4-preview-04ab3e60",
  "@metamask-previews/message-manager": "12.0.2-preview-04ab3e60",
  "@metamask-previews/messenger": "0.0.0-preview-04ab3e60",
  "@metamask-previews/multichain-account-service": "0.0.0-preview-04ab3e60",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-04ab3e60",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-04ab3e60",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-04ab3e60",
  "@metamask-previews/name-controller": "8.0.3-preview-04ab3e60",
  "@metamask-previews/network-controller": "24.0.1-preview-04ab3e60",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-04ab3e60",
  "@metamask-previews/permission-controller": "11.0.6-preview-04ab3e60",
  "@metamask-previews/permission-log-controller": "4.0.0-preview-04ab3e60",
  "@metamask-previews/phishing-controller": "13.1.0-preview-04ab3e60",
  "@metamask-previews/polling-controller": "14.0.0-preview-04ab3e60",
  "@metamask-previews/preferences-controller": "18.4.1-preview-04ab3e60",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-04ab3e60",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-04ab3e60",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-04ab3e60",
  "@metamask-previews/sample-controllers": "1.0.0-preview-04ab3e60",
  "@metamask-previews/seedless-onboarding-controller": "2.4.0-preview-04ab3e60",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-04ab3e60",
  "@metamask-previews/signature-controller": "31.0.1-preview-04ab3e60",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-04ab3e60",
  "@metamask-previews/transaction-controller": "58.1.1-preview-04ab3e60",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-04ab3e60"
}

@vinistevam
Copy link
Contributor Author

Just a sanity check - have we tested locally with given scenario to be sure fix working properly?

I've tested in a local branch, but now I created a draft PR with the preview build. MetaMask/metamask-mobile#17449

@vinistevam vinistevam merged commit b3cf3c0 into main Jul 22, 2025
219 checks passed
@vinistevam vinistevam deleted the fix/normalize-data-four-byte branch July 22, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants