-
-
Notifications
You must be signed in to change notification settings - Fork 242
Normalizes fourByte
data in method selector
#6102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a sanity check - have we tested locally with given scenario to be sure fix working properly?
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
I've tested in a local branch, but now I created a draft PR with the preview build. MetaMask/metamask-mobile#17449 |
Explanation
This PR updates the
getMethodName
utility to normalise the transaction data to lowercase before comparing it against known ABI method selectors.References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/5338
Changelog
Checklist