Skip to content

feat: swap transaction batching (tx type + non-stx batch support) #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jul 1, 2025

Explanation

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@micaelae micaelae requested a review from a team as a code owner July 1, 2025 01:34
cursor[bot]

This comment was marked as outdated.

@micaelae micaelae requested a review from a team as a code owner July 1, 2025 01:53
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@micaelae micaelae requested a review from a team as a code owner July 1, 2025 22:43
cursor[bot]

This comment was marked as outdated.

@micaelae micaelae changed the title feat: swap transaction batching feat: swap transaction batching (tx type + non-stx batch support) Jul 1, 2025
@micaelae micaelae changed the base branch from main to swaps1367-rm-user-operation-tx July 1, 2025 23:32
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sensitive Logs in Production Code

Two debug console.error statements were accidentally committed to production code. These statements log sensitive transaction metadata and clutter the console output, and should be removed.

packages/bridge-status-controller/src/bridge-status-controller.ts#L170-L171

({ transactionMeta }) => {
console.error('=====transactionFailed', transactionMeta);

packages/bridge-status-controller/src/bridge-status-controller.ts#L208-L209

console.error('=====transactionConfirmed', transactionMeta);

Fix in Cursor


Bug: Console Logs Sensitive Data in Production

Debug console.error statements were accidentally left in the BridgeStatusController's transactionFailed and transactionConfirmed handlers, logging sensitive transaction metadata to the console in production.

packages/bridge-status-controller/src/bridge-status-controller.ts#L208-L209

console.error('=====transactionConfirmed', transactionMeta);

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Base automatically changed from swaps1367-rm-user-operation-tx to main July 2, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant