-
-
Notifications
You must be signed in to change notification settings - Fork 242
feat: swap transaction batching (tx type + non-stx batch support) #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 429a514.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Sensitive Logs in Production Code
Two debug console.error
statements were accidentally committed to production code. These statements log sensitive transaction metadata and clutter the console output, and should be removed.
packages/bridge-status-controller/src/bridge-status-controller.ts#L170-L171
core/packages/bridge-status-controller/src/bridge-status-controller.ts
Lines 170 to 171 in 007e32e
({ transactionMeta }) => { | |
console.error('=====transactionFailed', transactionMeta); |
packages/bridge-status-controller/src/bridge-status-controller.ts#L208-L209
core/packages/bridge-status-controller/src/bridge-status-controller.ts
Lines 208 to 209 in 007e32e
console.error('=====transactionConfirmed', transactionMeta); |
Bug: Console Logs Sensitive Data in Production
Debug console.error
statements were accidentally left in the BridgeStatusController
's transactionFailed
and transactionConfirmed
handlers, logging sensitive transaction metadata to the console in production.
packages/bridge-status-controller/src/bridge-status-controller.ts#L208-L209
core/packages/bridge-status-controller/src/bridge-status-controller.ts
Lines 208 to 209 in 007e32e
console.error('=====transactionConfirmed', transactionMeta); |
Was this report helpful? Give feedback by reacting with 👍 or 👎
Explanation
References
Changelog
Checklist