feat(backup&sync): pair social login to SRP profile #6048

mirceanis · 2025-06-30T07:46:21Z

Explanation

This PR implements automatic social token pairing functionality for the AuthenticationController.
This change introduces automatic pairing that:

Detects access tokens from the SeedlessOnboardingController after successful SRP sign-in
Automatically attempts pairing without blocking the sign-in process
Maintains state to avoid redundant or concurrent pairing attempts
Handles failures ensuring that pairing issues don't affect core authentication

BREAKING CHANGES:

Adds @metamask/seedless-onboarding-controller as a peer dependency
Requires clients to allow SeedlessOnboardingControllerGetStateAction in their configuration for the AuthenticationController messenger
Requires matching the build type to the config.env in controller constructors

References

https://consensyssoftware.atlassian.net/browse/IDENTITY-150

Changelog

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

- Modify AuthenticationController to get accessToken from SeedlessOnboardingController state - Add pairing logic that runs non-blocking during signIn - Add state tracking for pairing status to prevent duplicate attempts - Add PAIR_SOCIAL_IDENTIFIER endpoint for social pairing API - Ensure pairing failures don't affect other authentication flows Based on PR #6048 but using accessToken from SeedlessOnboardingController (PR #6060) instead of injecting a separate socialPairingToken.

mirceanis · 2025-07-15T14:00:33Z

@metamaskbot publish-preview

github-actions · 2025-07-15T14:06:21Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.4.0-preview-d90711c",
  "@metamask-previews/accounts-controller": "31.0.0-preview-d90711c",
  "@metamask-previews/address-book-controller": "6.1.1-preview-d90711c",
  "@metamask-previews/announcement-controller": "7.0.3-preview-d90711c",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-d90711c",
  "@metamask-previews/approval-controller": "7.1.3-preview-d90711c",
  "@metamask-previews/assets-controllers": "71.0.0-preview-d90711c",
  "@metamask-previews/base-controller": "8.0.1-preview-d90711c",
  "@metamask-previews/bridge-controller": "35.0.0-preview-d90711c",
  "@metamask-previews/bridge-status-controller": "35.0.0-preview-d90711c",
  "@metamask-previews/build-utils": "3.0.3-preview-d90711c",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-d90711c",
  "@metamask-previews/composable-controller": "11.0.0-preview-d90711c",
  "@metamask-previews/controller-utils": "11.11.0-preview-d90711c",
  "@metamask-previews/delegation-controller": "0.5.0-preview-d90711c",
  "@metamask-previews/earn-controller": "3.0.0-preview-d90711c",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-d90711c",
  "@metamask-previews/ens-controller": "17.0.1-preview-d90711c",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-d90711c",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-d90711c",
  "@metamask-previews/foundryup": "1.0.0-preview-d90711c",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-d90711c",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-d90711c",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-d90711c",
  "@metamask-previews/keyring-controller": "22.1.0-preview-d90711c",
  "@metamask-previews/logging-controller": "6.0.4-preview-d90711c",
  "@metamask-previews/message-manager": "12.0.2-preview-d90711c",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-d90711c",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-d90711c",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-d90711c",
  "@metamask-previews/name-controller": "8.0.3-preview-d90711c",
  "@metamask-previews/network-controller": "24.0.0-preview-d90711c",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-d90711c",
  "@metamask-previews/permission-controller": "11.0.6-preview-d90711c",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-d90711c",
  "@metamask-previews/phishing-controller": "13.0.0-preview-d90711c",
  "@metamask-previews/polling-controller": "14.0.0-preview-d90711c",
  "@metamask-previews/preferences-controller": "18.4.1-preview-d90711c",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-d90711c",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-d90711c",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-d90711c",
  "@metamask-previews/sample-controllers": "1.0.0-preview-d90711c",
  "@metamask-previews/seedless-onboarding-controller": "2.1.0-preview-d90711c",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-d90711c",
  "@metamask-previews/signature-controller": "31.0.1-preview-d90711c",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-d90711c",
  "@metamask-previews/transaction-controller": "58.1.1-preview-d90711c",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-d90711c"
}

…ing of seedless onboarding profiles see MetaMask/core#6048 Signed-off-by: Mircea Nistor <mirceanis@gmail.com>

Copilot

Pull Request Overview

This PR implements automatic social token pairing functionality for the AuthenticationController to integrate with the SeedlessOnboardingController. The implementation allows for automatic pairing of social tokens during SRP sign-in without blocking the authentication process.

Adds social token pairing functionality to the authentication flow
Implements state management to prevent redundant/concurrent pairing attempts
Ensures pairing failures don't affect core authentication functionality

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts	Adds core social token pairing logic with state management
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.ts	Implements the pairSocialIdentifier method for SRP authentication
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts	Adds PAIR_SOCIAL_IDENTIFIER URL constant
packages/profile-sync-controller/src/sdk/authentication.ts	Exposes pairSocialIdentifier method in the main authentication interface
packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.test.ts	Adds comprehensive test coverage for social pairing functionality
packages/profile-sync-controller/src/sdk/authentication.test.ts	Adds test coverage for social identifier pairing
packages/profile-sync-controller/src/sdk/fixtures/auth.ts	Adds mock helper for social identifier pairing endpoint
packages/profile-sync-controller/src/sdk/mocks/auth.ts	Adds mock URL constant for social identifier pairing
packages/profile-sync-controller/package.json	Adds seedless-onboarding-controller as peer dependency
packages/profile-sync-controller/tsconfig.build.json	Adds TypeScript reference for seedless-onboarding-controller
packages/profile-sync-controller/CHANGELOG.md	Documents the breaking change
packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts	Minor typo fix in comment

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts

packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.ts

mathieuartu

LGTM! Will re-review and approve when the dependencies are merged. Left a couple of tiny comments 😄

...ages/profile-sync-controller/src/controllers/authentication/AuthenticationController.test.ts

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts

packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.ts

and try to use the token for automatic pairing after SRP login

…n for pairing BREAKING CHANGE: this adds @metamask/seedless-onboarding-controller as a peer dependency and requires clients to change their initialization of the controllers to allow `SeedlessOnboardingControllerGetStateAction` as well as match the build type to the `config.env` in the controller constructors.

…e condition

…ngle call to pairing endpoint

…g flow

mirceanis · 2025-07-18T11:21:35Z

@metamaskbot publish-preview

github-actions · 2025-07-18T11:27:43Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.4.0-preview-3713f9f",
  "@metamask-previews/accounts-controller": "31.0.0-preview-3713f9f",
  "@metamask-previews/address-book-controller": "6.1.1-preview-3713f9f",
  "@metamask-previews/announcement-controller": "7.0.3-preview-3713f9f",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-3713f9f",
  "@metamask-previews/approval-controller": "7.1.3-preview-3713f9f",
  "@metamask-previews/assets-controllers": "72.0.0-preview-3713f9f",
  "@metamask-previews/base-controller": "8.0.1-preview-3713f9f",
  "@metamask-previews/bridge-controller": "36.1.0-preview-3713f9f",
  "@metamask-previews/bridge-status-controller": "36.0.0-preview-3713f9f",
  "@metamask-previews/build-utils": "3.0.3-preview-3713f9f",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-3713f9f",
  "@metamask-previews/composable-controller": "11.0.0-preview-3713f9f",
  "@metamask-previews/controller-utils": "11.11.0-preview-3713f9f",
  "@metamask-previews/delegation-controller": "0.5.0-preview-3713f9f",
  "@metamask-previews/earn-controller": "3.0.0-preview-3713f9f",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-3713f9f",
  "@metamask-previews/ens-controller": "17.0.1-preview-3713f9f",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-3713f9f",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-3713f9f",
  "@metamask-previews/foundryup": "1.0.0-preview-3713f9f",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-3713f9f",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-3713f9f",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-3713f9f",
  "@metamask-previews/keyring-controller": "22.1.0-preview-3713f9f",
  "@metamask-previews/logging-controller": "6.0.4-preview-3713f9f",
  "@metamask-previews/message-manager": "12.0.2-preview-3713f9f",
  "@metamask-previews/messenger": "0.0.0-preview-3713f9f",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-3713f9f",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-3713f9f",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-3713f9f",
  "@metamask-previews/name-controller": "8.0.3-preview-3713f9f",
  "@metamask-previews/network-controller": "24.0.0-preview-3713f9f",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-3713f9f",
  "@metamask-previews/permission-controller": "11.0.6-preview-3713f9f",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-3713f9f",
  "@metamask-previews/phishing-controller": "13.1.0-preview-3713f9f",
  "@metamask-previews/polling-controller": "14.0.0-preview-3713f9f",
  "@metamask-previews/preferences-controller": "18.4.1-preview-3713f9f",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-3713f9f",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-3713f9f",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-3713f9f",
  "@metamask-previews/sample-controllers": "1.0.0-preview-3713f9f",
  "@metamask-previews/seedless-onboarding-controller": "2.3.0-preview-3713f9f",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-3713f9f",
  "@metamask-previews/signature-controller": "31.0.1-preview-3713f9f",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-3713f9f",
  "@metamask-previews/transaction-controller": "58.1.1-preview-3713f9f",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-3713f9f"
}

mirceanis · 2025-07-18T11:45:37Z

@metamaskbot publish-preview

github-actions · 2025-07-18T11:51:17Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.4.0-preview-91d59c3",
  "@metamask-previews/accounts-controller": "31.0.0-preview-91d59c3",
  "@metamask-previews/address-book-controller": "6.1.1-preview-91d59c3",
  "@metamask-previews/announcement-controller": "7.0.3-preview-91d59c3",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-91d59c3",
  "@metamask-previews/approval-controller": "7.1.3-preview-91d59c3",
  "@metamask-previews/assets-controllers": "72.0.0-preview-91d59c3",
  "@metamask-previews/base-controller": "8.0.1-preview-91d59c3",
  "@metamask-previews/bridge-controller": "36.1.0-preview-91d59c3",
  "@metamask-previews/bridge-status-controller": "36.0.0-preview-91d59c3",
  "@metamask-previews/build-utils": "3.0.3-preview-91d59c3",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-91d59c3",
  "@metamask-previews/composable-controller": "11.0.0-preview-91d59c3",
  "@metamask-previews/controller-utils": "11.11.0-preview-91d59c3",
  "@metamask-previews/delegation-controller": "0.5.0-preview-91d59c3",
  "@metamask-previews/earn-controller": "3.0.0-preview-91d59c3",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-91d59c3",
  "@metamask-previews/ens-controller": "17.0.1-preview-91d59c3",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-91d59c3",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-91d59c3",
  "@metamask-previews/foundryup": "1.0.0-preview-91d59c3",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-91d59c3",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-91d59c3",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-91d59c3",
  "@metamask-previews/keyring-controller": "22.1.0-preview-91d59c3",
  "@metamask-previews/logging-controller": "6.0.4-preview-91d59c3",
  "@metamask-previews/message-manager": "12.0.2-preview-91d59c3",
  "@metamask-previews/messenger": "0.0.0-preview-91d59c3",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-91d59c3",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-91d59c3",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-91d59c3",
  "@metamask-previews/name-controller": "8.0.3-preview-91d59c3",
  "@metamask-previews/network-controller": "24.0.0-preview-91d59c3",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-91d59c3",
  "@metamask-previews/permission-controller": "11.0.6-preview-91d59c3",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-91d59c3",
  "@metamask-previews/phishing-controller": "13.1.0-preview-91d59c3",
  "@metamask-previews/polling-controller": "14.0.0-preview-91d59c3",
  "@metamask-previews/preferences-controller": "18.4.1-preview-91d59c3",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-91d59c3",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-91d59c3",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-91d59c3",
  "@metamask-previews/sample-controllers": "1.0.0-preview-91d59c3",
  "@metamask-previews/seedless-onboarding-controller": "2.3.0-preview-91d59c3",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-91d59c3",
  "@metamask-previews/signature-controller": "31.0.1-preview-91d59c3",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-91d59c3",
  "@metamask-previews/transaction-controller": "58.1.1-preview-91d59c3",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-91d59c3"
}

…ing of seedless onboarding profiles see MetaMask/core#6048 Signed-off-by: Mircea Nistor <mirceanis@gmail.com>

mirceanis · 2025-07-21T11:35:49Z

@metamaskbot publish-preview

github-actions · 2025-07-21T11:41:32Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.4.0-preview-34e39226",
  "@metamask-previews/accounts-controller": "31.0.0-preview-34e39226",
  "@metamask-previews/address-book-controller": "6.1.1-preview-34e39226",
  "@metamask-previews/announcement-controller": "7.0.3-preview-34e39226",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-34e39226",
  "@metamask-previews/approval-controller": "7.1.3-preview-34e39226",
  "@metamask-previews/assets-controllers": "72.0.0-preview-34e39226",
  "@metamask-previews/base-controller": "8.0.1-preview-34e39226",
  "@metamask-previews/bridge-controller": "36.1.0-preview-34e39226",
  "@metamask-previews/bridge-status-controller": "36.0.0-preview-34e39226",
  "@metamask-previews/build-utils": "3.0.3-preview-34e39226",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-34e39226",
  "@metamask-previews/composable-controller": "11.0.0-preview-34e39226",
  "@metamask-previews/controller-utils": "11.11.0-preview-34e39226",
  "@metamask-previews/delegation-controller": "0.5.0-preview-34e39226",
  "@metamask-previews/earn-controller": "3.0.0-preview-34e39226",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-34e39226",
  "@metamask-previews/ens-controller": "17.0.1-preview-34e39226",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-34e39226",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-34e39226",
  "@metamask-previews/foundryup": "1.0.0-preview-34e39226",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-34e39226",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-34e39226",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-34e39226",
  "@metamask-previews/keyring-controller": "22.1.0-preview-34e39226",
  "@metamask-previews/logging-controller": "6.0.4-preview-34e39226",
  "@metamask-previews/message-manager": "12.0.2-preview-34e39226",
  "@metamask-previews/messenger": "0.0.0-preview-34e39226",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-34e39226",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-34e39226",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-34e39226",
  "@metamask-previews/name-controller": "8.0.3-preview-34e39226",
  "@metamask-previews/network-controller": "24.0.0-preview-34e39226",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-34e39226",
  "@metamask-previews/permission-controller": "11.0.6-preview-34e39226",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-34e39226",
  "@metamask-previews/phishing-controller": "13.1.0-preview-34e39226",
  "@metamask-previews/polling-controller": "14.0.0-preview-34e39226",
  "@metamask-previews/preferences-controller": "18.4.1-preview-34e39226",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-34e39226",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-34e39226",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-34e39226",
  "@metamask-previews/sample-controllers": "1.0.0-preview-34e39226",
  "@metamask-previews/seedless-onboarding-controller": "2.3.0-preview-34e39226",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-34e39226",
  "@metamask-previews/signature-controller": "31.0.1-preview-34e39226",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-34e39226",
  "@metamask-previews/transaction-controller": "58.1.1-preview-34e39226",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-34e39226"
}

…ocks

mirceanis · 2025-07-21T12:27:36Z

@metamaskbot publish-preview

github-actions · 2025-07-21T12:33:26Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.4.0-preview-849f6838",
  "@metamask-previews/accounts-controller": "31.0.0-preview-849f6838",
  "@metamask-previews/address-book-controller": "6.1.1-preview-849f6838",
  "@metamask-previews/announcement-controller": "7.0.3-preview-849f6838",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-849f6838",
  "@metamask-previews/approval-controller": "7.1.3-preview-849f6838",
  "@metamask-previews/assets-controllers": "72.0.0-preview-849f6838",
  "@metamask-previews/base-controller": "8.0.1-preview-849f6838",
  "@metamask-previews/bridge-controller": "36.1.0-preview-849f6838",
  "@metamask-previews/bridge-status-controller": "36.0.0-preview-849f6838",
  "@metamask-previews/build-utils": "3.0.3-preview-849f6838",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-849f6838",
  "@metamask-previews/composable-controller": "11.0.0-preview-849f6838",
  "@metamask-previews/controller-utils": "11.11.0-preview-849f6838",
  "@metamask-previews/delegation-controller": "0.5.0-preview-849f6838",
  "@metamask-previews/earn-controller": "3.0.0-preview-849f6838",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-849f6838",
  "@metamask-previews/ens-controller": "17.0.1-preview-849f6838",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-849f6838",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-849f6838",
  "@metamask-previews/foundryup": "1.0.0-preview-849f6838",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-849f6838",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-849f6838",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-849f6838",
  "@metamask-previews/keyring-controller": "22.1.0-preview-849f6838",
  "@metamask-previews/logging-controller": "6.0.4-preview-849f6838",
  "@metamask-previews/message-manager": "12.0.2-preview-849f6838",
  "@metamask-previews/messenger": "0.0.0-preview-849f6838",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-849f6838",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-849f6838",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-849f6838",
  "@metamask-previews/name-controller": "8.0.3-preview-849f6838",
  "@metamask-previews/network-controller": "24.0.0-preview-849f6838",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-849f6838",
  "@metamask-previews/permission-controller": "11.0.6-preview-849f6838",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-849f6838",
  "@metamask-previews/phishing-controller": "13.1.0-preview-849f6838",
  "@metamask-previews/polling-controller": "14.0.0-preview-849f6838",
  "@metamask-previews/preferences-controller": "18.4.1-preview-849f6838",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-849f6838",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-849f6838",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-849f6838",
  "@metamask-previews/sample-controllers": "1.0.0-preview-849f6838",
  "@metamask-previews/seedless-onboarding-controller": "2.3.0-preview-849f6838",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-849f6838",
  "@metamask-previews/signature-controller": "31.0.1-preview-849f6838",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-849f6838",
  "@metamask-previews/transaction-controller": "58.1.1-preview-849f6838",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-849f6838"
}

…ing of seedless onboarding profiles see MetaMask/core#6048 Signed-off-by: Mircea Nistor <mirceanis@gmail.com>

mirceanis mentioned this pull request Jun 30, 2025

chore(identity): bump profile-sync-controller package to enable pairing of social tokens MetaMask/metamask-extension#33976

Draft

7 tasks

mirceanis force-pushed the identity-150-auth-controller-ingest-social-token branch from 5fbb850 to aacb89d Compare July 15, 2025 13:24

mirceanis added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Jul 15, 2025

mirceanis force-pushed the identity-150-auth-controller-ingest-social-token branch from 5adccba to d90711c Compare July 15, 2025 13:56

mirceanis force-pushed the identity-150-auth-controller-ingest-social-token branch from cd03392 to 1df353f Compare July 15, 2025 15:16

mirceanis added the DO-NOT-MERGE label Jul 16, 2025

mirceanis marked this pull request as ready for review July 16, 2025 07:52

Copilot AI review requested due to automatic review settings July 16, 2025 07:52

mirceanis requested review from a team as code owners July 16, 2025 07:52

Copilot AI reviewed Jul 16, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

mathieuartu reviewed Jul 16, 2025

View reviewed changes

fabiobozzo reviewed Jul 16, 2025

View reviewed changes

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts Show resolved Hide resolved

fabiobozzo reviewed Jul 16, 2025

View reviewed changes

packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.ts Show resolved Hide resolved

fabiobozzo previously approved these changes Jul 16, 2025

View reviewed changes

mirceanis dismissed fabiobozzo’s stale review via 03d4641 July 17, 2025 10:16

This comment was marked as outdated.

Sign in to view

mirceanis added 6 commits July 18, 2025 12:17

feat: add new method to ingest the OAuth token from social login

f5a5e38

and try to use the token for automatic pairing after SRP login

chore: guard pairing calls from concurrent execution

6a0e97a

docs(profile-sync-controller): update the changelog

dd76bad

chore(profile-sync-controller): fix new linter warnings

4dd7155

chore(profile-sync-controller): fix yarn constraints

b65d75c

mirceanis added 7 commits July 18, 2025 12:17

test(profile-sync-controller): test new pairing functionality

bdf76dc

chore(profile-sync-controller): remove some of the TODOs

4ba8ebf

chore(profile-sync-controller): refactor pairing logic to prevent rac…

cf633b8

…e condition

test(profile-sync-controller): use waitFor instead of timeouts in tests

df0a2fe

test(profile-sync-controller): define mocked constants and enforce si…

3166dbf

…ngle call to pairing endpoint

test(profile-sync-controller): prevent sign-out race condition

6a168f5

chore(profile-sync-controller): remove console.log from social pairin…

3713f9f

…g flow

mirceanis force-pushed the identity-150-auth-controller-ingest-social-token branch from d060ed2 to 3713f9f Compare July 18, 2025 11:19

mirceanis removed the DO-NOT-MERGE label Jul 18, 2025

This comment was marked as outdated.

Sign in to view

chore(profile-sync-controller): bump devdeps

91d59c3

mirceanis force-pushed the identity-150-auth-controller-ingest-social-token branch from f4a2e14 to 91d59c3 Compare July 18, 2025 11:38

mirceanis changed the title ~~WIP Identity 150 auth controller ingest social token~~ feat(backup&sync): pair social login to SRP profile Jul 18, 2025

test(profile-sync-controller): allow Env customization for exported m…

0e69bd0

…ocks

mirceanis force-pushed the identity-150-auth-controller-ingest-social-token branch from 34e3922 to 0e69bd0 Compare July 21, 2025 11:48

chore(profile-sync-controller): bump peer deps

849f683

Uh oh!

feat(backup&sync): pair social login to SRP profile #6048

Are you sure you want to change the base?

feat(backup&sync): pair social login to SRP profile #6048

Uh oh!

Conversation

mirceanis commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

BREAKING CHANGES:

References

Changelog

Checklist

Uh oh!

mirceanis commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

mathieuartu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

mirceanis commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

mirceanis commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

mirceanis commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

mirceanis commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

Uh oh!

mirceanis commented Jun 30, 2025 •

edited

Loading