Add the h1_spending argument to gs_power_wlr
#561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdblischak
reviewed
Jul 3, 2025
| # Given the above statistical information calculate the power ---- | ||
| y_h1 <- gs_power_npe( | ||
| theta = x$theta, | ||
| theta = x$theta, theta0 = 0, theta1 = theta1, |
There was a problem hiding this comment.
Since all the other arguments are on their own line, I recommend keeping this consistent with the surrounding code and moving theta0 and theta1 to new lines
| theta = 0, | ||
| theta0 = 0, | ||
| theta1 = x$theta, | ||
| theta = 0, theta0 = 0, theta1 = theta1, |
| upar = list(sf = gsDesign::sfLDOF, total_spend = 0.025), | ||
| lower = gs_spending_bound, | ||
| lpar = list(sf = gsDesign::sfLDOF, total_spend = 0.025), | ||
| binding = TRUE, h1_spending = FALSE) |
There was a problem hiding this comment.
Love the test! For completeness, would it also make sense to have a test with h1_spending = TRUE to demonstrate that in that case the upper and lower bounds are not equal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue #560.