Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some combinations of LED strips broke compiling the code
In particular
Currently errors with
The cause is that both led strings use a common struct LEDColor
But LEDColor dynamically changes at compile time to include white support or not. It also only looked at NEOPIXEL_TYPE for a white led.
I separated the two led strings to use their own unique LEDColor that allows either to have a white led.
Requirements
#define NEOPIXEL_TYPE NEO_GRB
#define NEOPIXEL2_TYPE NEO_GRBW
#define NEOPIXEL2_SEPARATE
Benefits
Builds and works as expected
Configurations
Example config for a RAMPS with two LED strips
Example Configuration.zip
Related Issues