Skip to content

fix proui linear advance menu #27878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025
Merged

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented May 23, 2025

Description

Since #27818 Marlin does not build with proui and linear advance

Marlin/src/lcd/e3v2/proui/dwin.cpp:3549:104: error: lvalue required as unary '&' operand
 3549 |       EDIT_ITEM(ICON_MaxAccelerated, MSG_ADVANCE_K, onDrawPFloat3Menu, setLA_K, &planner.get_advance_k());

Updated code.

Requirements

DWIN_LCD_PROUI
LIN_ADVANCE

Benefits

Builds as expected

Configurations

Configuration.zip

Related Issues

#27818 (comment)

It was pointed out that a similar fix is also buried in #27858 in amongst all the pointless reformatting.

@thinkyhead thinkyhead merged commit d76c8c1 into MarlinFirmware:bugfix-2.1.x May 24, 2025
66 checks passed
@ellensp ellensp deleted the fix-proui branch May 25, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants