use vol for volume info in lpc176x upload script in windows. #27872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into a issue a user was having on a skr 1.4 controller I noticed a bug in the upload script under windows.
The script looks for either the volume name == REARM or root directory has the file FIRMWARE.CUR to identify the target media for the upload.
The script uses command line "dir" to get a root directory and the volume name.
The issue is when the media is empty, dir returns an error and the script loses the volume name.
So even if the volume name is REARM it is skipped.
Updated the script to use the vol command for the volume information, and use dir command for directory contents.
Requirements
A windows user using a Lpc176x based board
Benefits
Upload script finds the media with the correct volume name, even if the drive is empty