♻️ Motion encapsulation #27866
Open
♻️ Motion encapsulation #27866
+2,819
−2,901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_motion_encapsulation_PR
branch
13 times, most recently
from
90658b7 to
225ceea
Compare
thinkyhead
force-pushed
the
bf2_motion_encapsulation_PR
branch
15 times, most recently
from
6adbacb to
2774073
Compare
thinkyhead
force-pushed
the
bf2_motion_encapsulation_PR
branch
8 times, most recently
from
772d46e to
9344ccd
Compare
thinkyhead
force-pushed
the
bf2_motion_encapsulation_PR
branch
from
9344ccd to
95c1e6d
Compare
thinkyhead
force-pushed
the
bf2_motion_encapsulation_PR
branch
from
95c1e6d to
f4c6867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without changing too many semantics this PR aims to encapsulate all the motion data and code in a
Motionsingleton class, making it more obvious in the rest of the codebase which calls are being made to Marlin motion code versus similarly-named methods in other APIs.This is a work-in-progress along with a number of other refactors posted for CI testing. This PR will be followed up with encapsulation of
MarlinCore.*code in a "marlin" singleton object.