-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
Update and arrange fwretract, planner.settings #27848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
classicrocker883
wants to merge
26
commits into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
classicrocker883:bugfix-2.1.x-May3
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update and arrange fwretract, planner.settings #27848
classicrocker883
wants to merge
26
commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-May3
+505
−502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe389ee
to
832afd8
Compare
db0e559
to
8290012
Compare
e796b7a
to
481658d
Compare
481658d
to
c39db2e
Compare
ec27c62
to
5e95521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to
FWRETRACT
:Rename (shorten) Retract/RecoverRETRACT_RECOVER_LENGTH
=>RECOVER_LENGTH
swap_retract_recover_feedrate_mm_s
=>swap_recover_feedrate
Updates to
PlannerSettings
:Update - rearrange LCD menu options:
Requirements
Benefits
Better to keep it like the same, group stuff together. Have it in order across all other files.
Configurations
Related Issues
Important
In fwretract.cpp, some lines were added inorder for checks to be successful, because it pulls from configurations and Configuration_adv.h was changed. so these lines MUST be deleted before Merge.