Skip to content

Update and arrange fwretract, planner.settings #27848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented May 8, 2025

Description

Updates to FWRETRACT:

  • Rename (shorten) Retract/Recover
    • RETRACT_RECOVER_LENGTH => RECOVER_LENGTH
    • swap_retract_recover_feedrate_mm_s => swap_recover_feedrate

Updates to PlannerSettings:

  • Rearrange variables, move alike ones together (by M code numerical order)
  • Update menu displays with this order
  1. Acceleration
  2. Steps/mm
  3. Speed (Feedrate)

Update - rearrange LCD menu options:

  • Move the following in this order
    • Acceleration | Axis Steps/mm | Speed (Feedrate)

Requirements

Benefits

Better to keep it like the same, group stuff together. Have it in order across all other files.

Configurations

Related Issues

Important

In fwretract.cpp, some lines were added inorder for checks to be successful, because it pulls from configurations and Configuration_adv.h was changed. so these lines MUST be deleted before Merge.

@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-May3 branch from fe389ee to 832afd8 Compare May 8, 2025 21:30
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-May3 branch from db0e559 to 8290012 Compare May 8, 2025 23:33
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-May3 branch from e796b7a to 481658d Compare May 9, 2025 01:47
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-May3 branch from 481658d to c39db2e Compare May 9, 2025 01:58
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-May3 branch from ec27c62 to 5e95521 Compare May 13, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants