Skip to content

Add volumetric limit to tune menu #27811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

vovodroid
Copy link
Contributor

This allows more handy speed limit editing in real time.

@vovodroid vovodroid force-pushed the tune-vol-limit-pr branch from 8ab3bc5 to d8bff68 Compare May 4, 2025 06:43
@vovodroid vovodroid force-pushed the tune-vol-limit-pr branch from d8bff68 to 8b71a72 Compare May 4, 2025 06:44
@vovodroid
Copy link
Contributor Author

May be float31? 12.3 good enough.

@vovodroid
Copy link
Contributor Author

vovodroid commented May 4, 2025

By a way, for what it's worth, float specifiers, including float_42_52 produce precision errors, resulting in inability to set zero value:
image

In this case it sets limit to 0.001 instead of disabling it, actually ruining the print.

@thinkyhead
Copy link
Member

In general rational numbers don't make for the most perfectly rounded float values, but I'll look closer at unscaleEncoder to see how it can perform more perfect rounding to the specified 100ths precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants