-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
Edit CONFIGURABLE_MACHINE_NAME - M550 #27772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
classicrocker883
wants to merge
15
commits into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
classicrocker883:bugfix-2.1.x-March7
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Edit CONFIGURABLE_MACHINE_NAME - M550 #27772
classicrocker883
wants to merge
15
commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-March7
+34
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0806931
to
62639d4
Compare
34fb5e7
to
1a8fd8a
Compare
Sorry for the current broken CI testing. I'm reviewing some old sanity checks that are either obsolete or just interesting. Testing each of these with different variations of M550 P"Quoted Parm1"
M550 P "Quoted Parm2"
M550 P "Unclosed Parm3\
M550 P"Name \"too\" incredibly long to store the whole entire lengthy appellation."
M550 PUnquoted Spaced
M550 P Unq.Spaced Two
M550 String Name P24
M550 "Quoted String"
M550 P3DPrinter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #27731
CONFIGURABLE_MACHINE_NAME
M550.cpp
GCODE_QUOTED_STRINGS
disabled.Requirements
Benefits
More options with
M550
Related Issues
Upon starting a printer, like Ender-3V2, the Welcome MSG usually says "
MACHINE_NAME
Ready."or
"3D Printer Ready."
however, when it is defined as
"$"
, this becomes "$ Ready." on startingApparently in according to settings.cpp the remedy is to reset. So after first flashing the firmware, that is the issue.