Skip to content

Edit CONFIGURABLE_MACHINE_NAME - M550 #27772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Mar 31, 2025

Description

Followup to #27731 CONFIGURABLE_MACHINE_NAME

M550.cpp

  • Allow printer name change with GCODE_QUOTED_STRINGS disabled.
    • However, this results in name only in Capital letters
  • Remove SanityCheck limitation.
  • ~~Allow feedback when name is changed. ~~
  • Allow without parameters to just print the name

Requirements

Benefits

More options with M550

Related Issues

Upon starting a printer, like Ender-3V2, the Welcome MSG usually says "MACHINE_NAME Ready."
or
"3D Printer Ready."

however, when it is defined as "$", this becomes "$ Ready." on starting

Apparently in according to settings.cpp the remedy is to reset. So after first flashing the firmware, that is the issue.

@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-March7 branch from 0806931 to 62639d4 Compare April 1, 2025 03:34
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-March7 branch from 34fb5e7 to 1a8fd8a Compare April 1, 2025 05:32
@thinkyhead
Copy link
Member

Sorry for the current broken CI testing. I'm reviewing some old sanity checks that are either obsolete or just interesting.

Testing each of these with different variations of FASTER_GCODE_PARSER, GCODE_QUOTED_STRINGS, and GCODE_CASE_INSENSITIVE produces interesting results. Try them out in the Simulator with some extra debugging.

M550 P"Quoted Parm1"
M550 P "Quoted Parm2"
M550 P "Unclosed Parm3\
M550 P"Name \"too\" incredibly long to store the whole entire lengthy appellation."
M550 PUnquoted Spaced
M550 P Unq.Spaced Two
M550 String Name P24
M550 "Quoted String"
M550 P3DPrinter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants