-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
Various fixes: missed code uses, other updates #27711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
classicrocker883
wants to merge
35
commits into
MarlinFirmware:bugfix-2.1.x
Choose a base branch
from
classicrocker883:bugfix-2.1.x-February2
base: bugfix-2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Various fixes: missed code uses, other updates #27711
classicrocker883
wants to merge
35
commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-February2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove extra `"`
… into bugfix-2.1.x-February2
… into bugfix-2.1.x-February2
4354891
to
efa1758
Compare
… into bugfix-2.1.x-February2
… into bugfix-2.1.x-February2
Closed
classicrocker883
added a commit
to classicrocker883/Marlin
that referenced
this pull request
Apr 6, 2025
e6ff7af
to
95c8f12
Compare
… into bugfix-2.1.x-February2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No real category to put these changes in, so here goes
FLIP()
to missed opportunity placement;
typo from PlatformIO/scripts/STM32F1_create_variant.pyICON_ShapingZ
import ...
to prevent error of it missing in a.py
file.Updates and fixes to various files.
Taken from other PR (#27277)
#if HAS_LEVELING && HAS_ZOFFSET_ITEM)
=>#if ALL(HAS_LEVELING, HAS_ZOFFSET_ITEM)
HAS_DWIN_E3V2
intoHAS_DISPLAY
HAS_UI_UPDATE
CREALITY_V4
in pins.h to include RC board env type.for printcounter.cpp would have to ask @thinkyhead
- Other changes and good things
- fix this same error in share/scripts/g29_auto.py:
#doesnt have to say
"Error: Unable to determine layer range. Exiting."
per say, or toexit
, but its suggestedalso, near the end of this file, you will see
#
file.close()
should bein_file.close()
, but the code has since been improved differently.- Add
FLIP()
to missed opportunity placementin module/tempurature.cpp
Requirements
Benefits
Configurations
Related Issues