(feature) re-parametrized splitting to 1/k0 terms #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed, this changes how the 'uniform' splitting method works to make the definition be in terms of mobility instead of scans.
The change requires passing around a reference to a scan to im converter.
In addition there is a minor refactor to pass a reference to SqlReader instead of passing a path that then will be used to read another SqlReader (which might save a couple of ms here and there).
LMK what you think! happy to make any changes needed.