Skip to content

(feature) re-parametrized splitting to 1/k0 terms #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jspaezp
Copy link
Contributor

@jspaezp jspaezp commented Aug 1, 2024

As we discussed, this changes how the 'uniform' splitting method works to make the definition be in terms of mobility instead of scans.

The change requires passing around a reference to a scan to im converter.

In addition there is a minor refactor to pass a reference to SqlReader instead of passing a path that then will be used to read another SqlReader (which might save a couple of ms here and there).

LMK what you think! happy to make any changes needed.

@sander-willems-bruker sander-willems-bruker changed the base branch from develop_SW to develop August 22, 2024 13:20
@sander-willems-bruker
Copy link
Collaborator

Thanks for the good work! At a quick glance most looks like I'd expect it to (haven't run the code just yet). Few comments I already can make before testing locally:

  • I changed base to develop, this way you avoid merge conflicts and I can handle them on my end if needed.
  • Currently a panic occurs if there is no converter while required. I probably want to change that to error propagation rather than a panic.
  • I would like to have the choice to use either scan indices or im values. I.e. add your work to existing code base rather than replace the scan option

@jspaezp
Copy link
Contributor Author

jspaezp commented Aug 27, 2024

@sander-willems-bruker I believe its good to go, LMK what you think.

@sander-willems-bruker
Copy link
Collaborator

Merged into develop via #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants