Skip to content

[feature] handle new fields for virtual accounts #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[feature] handle new fields for virtual accounts #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions mangopay/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ def api_value(self, value):
class LocalAccountDetailsField(Field):
def python_value(self, value):
if value is not None:
return LocalAccountDetails(address=value['Address'], account=value['Account'])
return LocalAccountDetails(address=value['Address'], account=value['Account'], bank_name=value['BankName'])
return value

def api_value(self, value):
Expand All @@ -977,7 +977,8 @@ def api_value(self, value):
if isinstance(value, LocalAccountDetails):
value = {
'Address': value.address,
'Account': value.account
'Account': value.account,
'BankName': value.bank_name
}

return value
Expand All @@ -986,7 +987,8 @@ def api_value(self, value):
class InternationalAccountDetailsField(Field):
def python_value(self, value):
if value is not None:
return InternationalAccountDetails(address=value['Address'], account=value['Account'])
return InternationalAccountDetails(address=value['Address'], account=value['Account'],
bank_name=value['BankName'])
return value

def api_value(self, value):
Expand All @@ -995,7 +997,8 @@ def api_value(self, value):
if isinstance(value, InternationalAccountDetails):
value = {
'Address': value.address,
'Account': value.account
'Account': value.account,
'BankName': value.bank_name
}

return value
Expand Down
2 changes: 2 additions & 0 deletions mangopay/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2615,6 +2615,8 @@ class VirtualAccount(BaseModel):
local_account_details = LocalAccountDetailsField(api_name='LocalAccountDetails')
international_account_details = ListField(api_name='InternationalAccountDetails')
capabilities = VirtualAccountCapabilitiesField(api_name='Capabilities')
result_code = CharField(api_name='ResultCode')
result_message = CharField(api_name='ResultMessage')

class Meta:
verbose_name = 'virtual_account'
Expand Down
20 changes: 12 additions & 8 deletions mangopay/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,34 +1041,38 @@ def to_api_json(self):


class LocalAccountDetails(object):
def __init__(self, address=None, account=None):
def __init__(self, address=None, account=None, bank_name=None):
self.address = address
self.account = account
self.bank_name = bank_name

def __str__(self):
return 'LocalAccountDetails: %s %s' % \
(self.address, self.account)
return 'LocalAccountDetails: %s %s %s' % \
(self.address, self.account, self.bank_name)

def to_api_json(self):
return {
"Address": self.address,
"Account": self.account
"Account": self.account,
"BankName": self.bank_name
}


class InternationalAccountDetails(object):
def __init__(self, address=None, account=None):
def __init__(self, address=None, account=None, bank_name=None):
self.address = address
self.account = account
self.bank_name = bank_name

def __str__(self):
return 'InternationalAccountDetails: %s %s' % \
(self.address, self.account)
return 'InternationalAccountDetails: %s %s %s' % \
(self.address, self.account, self.bank_name)

def to_api_json(self):
return {
"Address": self.address,
"Account": self.account
"Account": self.account,
"BankName": self.bank_name
}


Expand Down
3 changes: 3 additions & 0 deletions tests/test_virtual_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ def test_create_virtual_account(self):

self.assertIsNotNone(virtual_account)
self.assertEqual(virtual_account.status, 'ACTIVE')
self.assertEqual(virtual_account.result_message, 'Success')
self.assertEqual(virtual_account.result_code, '000000')
self.assertIsNotNone(virtual_account.local_account_details.bank_name)

def test_get_virtual_account(self):
virtual_account = BaseTestLive.create_new_virtual_account()
Expand Down
Loading