Skip to content

Allow subclassing from missing dependency #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions generalimport/fake_module.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from typing import Optional
import sys
from functools import partialmethod
from generalimport import MissingOptionalDependency
from generalimport.exception import MissingOptionalDependency, MissingDependencyException


Expand Down Expand Up @@ -43,6 +45,22 @@ def __getattr__(self, item):
fakemodule.error_func()
return FakeModule(spec=self.__spec__, trigger=item)

def __mro_entries__(self, *a, **k):
"""
This prevents the creation of subclasses from triggering `generalimport`.

The classes so generated will trigger generalimport as soon as they're instantiated.
"""
class FakeBaseClass:

def __new__(fake_cls, *args, **kwargs):
self.error_func("__new__")

def __init__(fake_self, *args, **kwargs):
self.error_func("__init__")

return (FakeBaseClass, )

# Binary
__ilshift__ = __invert__ = __irshift__ = __ixor__ = __lshift__ = __rlshift__ = __rrshift__ = __rshift__ = error_func

Expand Down
38 changes: 30 additions & 8 deletions generalimport/test/test_usage/test_object.py
Original file line number Diff line number Diff line change
@@ -1,26 +1,48 @@
import sys
from unittest import skip

import generalimport as gi
from generalimport import *

from generalimport.test.funcs import ImportTestCase


class Test(ImportTestCase):
def test_init_subclass(self):
""" This one is caught by __call__. """
def test_subclass_class_returning_self(self):
generalimport("fakepackage")
import fakepackage

class SubClass(fakepackage.BaseClass):
pass

foo = SubClass.bar # Won't error if SubClass is a FakeModule

with self.assertRaises(MissingDependencyException):
class X(fakepackage):
pass
foo *= 2

def test_subclass_module(self):
generalimport("fakepackage")
import fakepackage

class X(fakepackage):
pass

with self.assertRaises(MissingDependencyException):
X()

def test_subclass_class(self):
generalimport("fakepackage")
import fakepackage

class SubClass(fakepackage.BaseClass):
def __init__(self):
raise ValueError("'generalimport' should fail earlier with MissingDependencyException")

self.assertRaises(MissingDependencyException, SubClass)

def test_subclass_class_direct_new_call(self):
generalimport("fakepackage")
import fakepackage

class SubClass(fakepackage.BaseClass):
def __init__(self):
raise ValueError("'generalimport' should fail earlier with MissingDependencyException")

with self.assertRaises(MissingDependencyException):
SubClass.__new__(SubClass)