Skip to content

specapi: improve distance_score performance #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

specapi: improve distance_score performance #5002

wants to merge 1 commit into from
+34 −22

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented May 22, 2025

distance_score is used in plot updates, and I saw it dominating in my @profview.

This PR:

  • avoids unnecessary allocations of large scores arrays
  • and makes it stop computing the score when it is clear that the difference is larger than the current threshold

@github-project-automation github-project-automation bot moved this to Work in progress in PR review May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR review
Status: Work in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aplavin