Series now uses Wong colors #4969
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes it so it uses Wong colors, but it's hardcoded and wrong. It should default to the default color cycle of the current palette. I don't know how to do it. |
asinghvi17
reviewed
May 23, 2025
| @@ -11,7 +11,7 @@ If any of `marker`, `markersize`, `markercolor`, `strokecolor` or `strokewidth` | |||
| """ | |||
| @recipe Series (curves::AbstractVector{<:Union{BezierPath,AbstractVector{<:Point}}},) begin | |||
| linewidth=2 | |||
| color=:lighttest | |||
| color=wong_colors() | |||
There was a problem hiding this comment.
inherit(:palette, wong_colors()) ish should do it, I just don't know what the sequence of keys is in the palette to get to the colors of lines. Maybe inherit((:palette, :colors), wong_colors())? I can't remember if I added this syntax though or what the palette looks like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4926
Type of change
Delete options that do not apply:
Checklist