Add sources to all Project.tomls #4967
Open
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsSHA: b2fe32d9c019bb612af0054bdb2947796f130cda Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
t-bltg
reviewed
May 11, 2025
| @@ -40,3 +40,6 @@ Printf = "1.0, 1.6" | |||
| ShaderAbstractions = "0.5" | |||
| StaticArrays = "0.12, 1.0" | |||
| julia = "1" | |||
|
|
|||
| [sources] | |||
| Makie = { path = ".." } | |||
There was a problem hiding this comment.
Should
[sources]
ReferenceTests = {path = "../../ReferenceTests"}
be added to GLMakie/test/Project.toml (same remark for CairoMakie/test and WGLMakie/test) ?
I think ReferenceTests = "d37af2e0-5618-4e00-9939-d430db56ee94" can also be removed from GLMakie/Project.toml (only used in tests, it is a leftover ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if you dev Makie, it will automatically dev the local MakieCore as well. If you dev a backend it should dev both Makie and MakieCore.
Sources does not apply if you are not in the project.toml or not dev'ing the project. So regular package downloads just get the normal published MakieCore.