Handle dim_conversions
in Axis3
#4964
Open
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4963.
This is my attempt on fixing the issue #4963 I created, namely handling
DimConversions
inAxis3
. It solves the problem I reported in the issue, but I cannot judge whether this is a full solution, so maybe some expert should review and judge the completeness of this.I looked into how
dim_conversion
is handled inAxis
, and it looks like, inAxis3
,axis
were just not passed to the newly createdScene
when initializing the blockget_ticks
when creating the ticknodes.This should be fixed now in this PR.
Example 1:
Before this PR:
ax.scene.conversions
would ignore what was passed and the axis ticklabels would not show the unit.Using this PR:
The
ax.scene.conversions
has thedim_conversion
passed to it and the axis ticklabels show units now.Example 2:
Before this PR:
ax.scene.conversions
would "guess" the unit conversion (automatic
), in this casedm
(decimeter) but not display them --> BUGUsing this PR:
ax.scene.conversions
would still use thedim_conversion
defined when creating theAxis3
Type of change
Checklist