improve wireframe poly of meshes significantly

[SimonDanisch]

 poly(Sphere(Point3f(0), 1), color=:white, strokewidth=1, strokecolor=:black, shading=true)

[SimonDanisch]

For full effect, I needed a much larger depth_shift.
@ffreyer, I guess the correct value is a bit scene dependent?

[MakieBot]

Benchmark Results

SHA: 2a01c778515656b334f8645d9fe35ac6e7f4dfb9

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

[jkrumbiegel]

One problem might be if you have folds or creases in the mesh, then depth shift might pull the lines from the back through the front. That's why I still think mesh + wireframes should be a separate shader where the distance from the face edge determines whether you draw stroke color or face color

[SimonDanisch]

That's why I still think mesh + wireframes should be a separate shader

I think so too, but its just so much work :D

[SimonDanisch]

Well, I guess the reference images show we cant just up the depth_shift that much ^^

[ffreyer]

For full effect, I needed a much larger depth_shift. @ffreyer, I guess the correct value is a bit scene dependent?

Depth shift applies in clip space so no matter what your camera does, you're always acting on a -1..1 range (or was it 0..1, I always forget)

One problem might be if you have folds or creases in the mesh, then depth shift might pull the lines from the back through the front.

Yea pretty much. You shift the lines forward so if your mesh is thinner in clip space than depth_shift the lines from the backside will poke through