-
-
Notifications
You must be signed in to change notification settings - Fork 344
Annotate recipe #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jkrumbiegel
wants to merge
23
commits into
master
Choose a base branch
from
jk/annotate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Annotate recipe #4891
+935
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsSHA: ef03e1f9b26c857f9f894fb2112375e162d2c07f Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
I'd love this! Any reason preventing merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
annotate
recipe which is a sort of hybrid between ggrepel, which annotates a bunch of points with labels that should avoid each other, and matplotlib-style annotations where arrows can be drawn from text labels to targets with lots of style options.If an array of labels is given with no explicit text positions, labels are iteratively moved in order to overlap less with each other and the data points:
Text positions can be given in data space or in offset space (default) so that it's easy to move the text just some visual distance away from the annotated thing.
@ffreyer Ideally we could combine this with the textlabel recipe from #4879 somehow so that each label could have a background shape as well?