Skip to content

Bump C++ standard to C++17 (autotools) #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

d-torrance
Copy link
Member

This is necessary if we want to use googletest 1.17.0

This is necessary if we want to use googletest 1.17.0
@d-torrance d-torrance requested a review from mikestillman June 7, 2025 20:41
@mikestillman
Copy link
Member

I definitely want to be on c++ version at least c++17... So if the build is ok, definitely let's do it. In fact, we should be trying c++20 too, but that will be another PR. Question: which versions of ubuntu support c++17, c++20?

Copy link
Member

@mikestillman mikestillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the builds finish with no errors, upgrading to c++17 is a good idea! Thanks!

@d-torrance
Copy link
Member Author

According to https://gcc.gnu.org/projects/cxx-status.html:

  • C++17 has been almost completely supported since GCC 7, which is available in Ubuntu 18.04
  • C++20 has a been almost completely supported since GCC 11, which is available in Ubuntu 22.04

@d-torrance d-torrance merged commit fef0bca into Macaulay2:development Jun 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants