Use simde to accelerate for loongarch #1054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaartenBaert, ping. |
|
This looks much better, the only issue I see is that it includes the entire simde library into the SSR repository, which is unnecessary since simde is widely available as a system package. Please use CMake to find the simde system package like it is done for all other external libraries (you can find examples in the cmake directory). I would normally do it myself, but I have no way to test this since I don't have this CPU. |
|
@MaartenBaert , thanks for your review, I have made changes according to your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have integrated simde into AV subdirectory and removed unused files, which does not need system-dependent simde header files. We have tested locally on X86 and LoongArch platform, it seems everything is fine. Reviews are welcome. Thanks.