Add support for ARM-based Apple Silicon architecture on macOS #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required a bit of refactoring in the discovery code. We now detect the platform architecture right upfront and use it to inform our expectation of the name of Comsol's binary folder, such as `win64` or `macarm64`. We don't expect it to behave any different on platforms that were previously already supported.
Co-authored-by: Marie Houillon <houillonmarie@gmail.com>
john-hen
force-pushed
the
support-macarm
branch
from
8700d1a to
3e38f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a bit of refactoring in the discovery code. We now detect the platform architecture right upfront and use it to inform our expectation of the name of Comsol's binary folder, such as
win64ormacarm64. We don't expect it to behave any different on platforms that were previously already supported.Supersedes (but includes) #227. Solves #80.