Skip to content

Brainstorming, domain_study readme, key_terms, resources_links, and folder structuring #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 15, 2025

Conversation

linahKhayri
Copy link

@linahKhayri linahKhayri commented Jun 15, 2025

#45 #40
We added the brainstorming and files structures in the domain_study

name: General PR template
about: A template with a generic and high-level review checklist, feel free to modify the checklists based on your PR.

General Checks

  • the branch is up to date with main
  • the code works when pulled and run locally
  • All CI checks pass (or at least discussed)
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

@linahKhayri linahKhayri added the documentation Improvements or additions to documentation label Jun 15, 2025
@ObayCipher ObayCipher self-requested a review June 15, 2025 15:27
Copy link

@ObayCipher ObayCipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and Professional 👍

@ObayCipher ObayCipher merged commit d1386a6 into main Jun 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants