Skip to content

Strang Splitting for lagrange bubbles #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 19, 2025

Addressing comments 3 and fixing Frontier

81121a7
Select commit
Loading
Failed to load commit list.
Merged

Strang Splitting for lagrange bubbles #827

Addressing comments 3 and fixing Frontier
81121a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 17, 2025 in 0s

43.35% (target 1.00%)

View this Pull Request on Codecov

43.35% (target 1.00%)

Details

Codecov Report

Attention: Patch coverage is 56.07143% with 123 lines in your changes missing coverage. Please review.

Project coverage is 43.35%. Comparing base (40164cf) to head (81121a7).

Files with missing lines Patch % Lines
src/simulation/m_bubbles_EL.fpp 35.35% 56 Missing and 8 partials ⚠️
src/simulation/m_bubbles.fpp 74.79% 13 Missing and 18 partials ⚠️
src/simulation/m_bubbles_EL_kernels.fpp 0.00% 6 Missing ⚠️
src/simulation/m_rhs.fpp 53.84% 4 Missing and 2 partials ⚠️
src/simulation/m_bubbles_EE.fpp 50.00% 4 Missing and 1 partial ⚠️
src/simulation/m_start_up.fpp 28.57% 3 Missing and 2 partials ⚠️
src/simulation/m_time_steppers.fpp 72.22% 3 Missing and 2 partials ⚠️
src/common/m_checker_common.fpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   43.15%   43.35%   +0.19%     
==========================================
  Files          68       68              
  Lines       20262    20125     -137     
  Branches     2424     2398      -26     
==========================================
- Hits         8745     8725      -20     
+ Misses      10054     9934     -120     
- Partials     1463     1466       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov