chore: refactoring (part 1) #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: develop-cs <43383361+develop-cs@users.noreply.github.com>
Signed-off-by: develop-cs <43383361+develop-cs@users.noreply.github.com>
Signed-off-by: develop-cs <43383361+develop-cs@users.noreply.github.com>
Signed-off-by: develop-cs <43383361+develop-cs@users.noreply.github.com>
develop-cs
changed the title
Signed-off-by: develop-cs <43383361+develop-cs@users.noreply.github.com>
GratienDSX
previously approved these changes
Jan 6, 2025
Collaborator
GratienDSX
left a comment
GratienDSX
left a comment
There was a problem hiding this comment.
Great work, it significantly improves overall readability. I left one comment for the sake.
ThomasBouche
previously approved these changes
Jan 6, 2025
Signed-off-by: GratienDSX <11066079+GratienDSX@users.noreply.github.com>
GratienDSX
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧
In progressPart 1 🚧The main idea is to make meteole interfaces untied to models and clients. This would give meteole the ability to access various forecast models from different sources (i.e., from different clients).
Here are things to work on (only suggestions) in a second part:
Forecastclass is highly tied to MeteoFrance models --> Maybe we should extract common attributes and methods of forecast models into aBaseForecast(abstract class) and create another abstract classMeteoFranceForecast(base class ofArpegeForecastandAromeForecast, two concrete and final classes)?