Skip to content

Fix Tests: Reduce to 0 MeteoFranceClient.RETRY_DELAY_SEC #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix Tests: Reduce to 0 MeteoFranceClient.RETRY_DELAY_SEC #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a3e3a
Fix tests: reduce MeteoFranceClient.RETRY_DELAY_SEC to 0 to avoid wai…
Jan 31, 2025
e26d033
Merge branch 'main' into test/reduce_retry_delay
GratienDSX Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/test_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_get_request_success(mock_get_token, mock_get):
mock_response.json.return_value = {"data": "some data"}
mock_get.return_value = mock_response

response = api.get("https://dummyurl.com")
response = api.get("DUMMY_PATH")
assert response.status_code == 200
assert response.json() == {"data": "some data"}

Expand All @@ -60,6 +60,7 @@ def test_get_request_success(mock_get_token, mock_get):
@patch.object(MeteoFranceClient, "_get_token")
def test_get_request_token_expired(mock_get_token, mock_get):
api = MeteoFranceClient(api_key="dummy_api_key")
api.RETRY_DELAY_SEC = 0

expired_response = MagicMock()
expired_response.status_code = 401
Expand All @@ -72,11 +73,11 @@ def test_get_request_token_expired(mock_get_token, mock_get):

mock_get.side_effect = [expired_response, valid_response, valid_response]

response = api.get("https://dummyurl.com")
response = api.get("DUMMY_PATH")
assert response.status_code == 200
assert response.json() == {"data": "some data"}

response = api.get("https://dummyurl.com")
response = api.get("DUMMY_PATH")
assert response.status_code == 200
assert response.json() == {"data": "some data"}

Expand Down Expand Up @@ -105,6 +106,7 @@ def test_token_not_expired():
@patch.object(MeteoFranceClient, "_get_token")
def test_get_request_specific_error(mock_get_token, mock_get):
api = MeteoFranceClient(api_key="dummy_api_key")
api.RETRY_DELAY_SEC = 0

error_response = MagicMock()
error_response.status_code = 502
Expand All @@ -116,7 +118,7 @@ def test_get_request_specific_error(mock_get_token, mock_get):

mock_get.side_effect = [error_response, valid_response]

response = api.get("https://dummyurl.com")
response = api.get("DUMMY_PATH")
assert response.status_code == 200
assert response.json() == {"data": "some data"}
assert mock_get.call_count == 2