Skip to content

Conversation

@GratienDSX
Copy link
Collaborator

@GratienDSX GratienDSX commented Jan 22, 2025

  • Add class AromePIForecast
  • Convert forecast_horizon to dt.timedelta
  • Add class PiafForecast
  • Override default API_BASE_URL - Piaf model still is on old URL api.meteofrance.fr/pro/
  • Documentation

@GratienDSX GratienDSX linked an issue Jan 22, 2025 that may be closed by this pull request
@GratienDSX GratienDSX changed the title Arome Instantane (PIAF Arome Instantane (PIAF) Jan 22, 2025
@GratienDSX GratienDSX self-assigned this Jan 23, 2025
@GratienDSX GratienDSX changed the title Arome Instantane (PIAF) Additional models : Arome Instantane, PIAF Jan 28, 2025
@GratienDSX GratienDSX force-pushed the feature/arome_instantane branch from 5073b6e to 565ef1d Compare January 28, 2025 16:18
ThomasBouche
ThomasBouche previously approved these changes Jan 29, 2025
Copy link
Collaborator

@ThomasBouche ThomasBouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the 2 tutorials with the 2 new models?
It could be good, it's like integration testing.

@GratienDSX GratienDSX force-pushed the feature/arome_instantane branch from 1f87ee3 to c1be1f6 Compare January 30, 2025 13:42
@GratienDSX
Copy link
Collaborator Author

GratienDSX commented Jan 30, 2025

Rebased on main branch.

@GratienDSX GratienDSX merged commit c308150 into main Jan 31, 2025
4 checks passed
@GratienDSX GratienDSX deleted the feature/arome_instantane branch January 31, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the model PIAF to the forecasting models

4 participants