implemented code for http_file flags #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The PR looks good to me. |
M4urici0GM
approved these changes
Feb 6, 2025
Collaborator
Author
|
Thank you for the feedback. I will provide the example. |
M4urici0GM
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented HTTP upload file flags by adding the necessary flags and helper functions, all sourced from Shaka Packager's [hls_flags.cc](https://github.com/shaka-project/shaka-packager/blob/c819deaa2376399a89d41f3804bc72f4a20d9d6d/packager/app/hls_flags.cc). This enables HTTP file uploads using well-established configurations from Shaka Packager. For more details on HTTP upload support, refer to the [Shaka Packager HTTP Upload tutorial](https://shaka-project.github.io/shaka-packager/html/tutorials/http_upload.html).