Skip to content

fix baseUrl and an simple fix for multiple types in an param (in v2\explorer) #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

timmit-nl
Copy link

I have noticed the baseUrl doens't work as I would expect (remove it from the path to check for the correct route).

This fixes that.

Also we have some issues with multiple types of an param in Explorer v2:
/**

  • test function
  • @param string|null $testVar
  • @return void
    **/
    testFunction(?string $testVar) : void

So the quick fix is to only gets the first type.

And my editor fixes some PRS12 incorrections when I saved the file. It makes it better to read, so I left them.

@timmit-nl
Copy link
Author

this last commits is that if you use a baseUrl with domain (like the tool will generate if not there, so I think it is the propper use) it strips it from the path. So you get an clean path.
Also an fix that if you use a baseUrl without domain you get a notice in src/Explorer/v2/Explorer.php

@timmit-nl
Copy link
Author

I will close this one as I have a new clean version of only the baseUrl problem: #671

@timmit-nl timmit-nl closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant