Fix Vulkan WSI instance extensions #2213
Conversation
This commit fixes 3 bugs: - `VK_EXT_HEADLESS_SURFACE_EXTENSION_NAME` missing in `kSurfaceExtensions` - `cli_wsi_extension_` not being set (nor possible to set) when replaying on Android - If offscreen content is captured and replayed specifying a WSI, it was possible to end up with instance extensions containing a surface extension but no `VK_KHR_surface` Change-Id: I51d89bd639b6f7bc32f045c872d697c0dec1a54c
|
CI gfxreconstruct build queued with queue ID 447478. |
|
CI gfxreconstruct build # 6892 running. |
|
CI gfxreconstruct build # 6892 passed. |
| Application(const std::string& name, | ||
| decode::FileProcessor* file_processor, | ||
| const std::string& cli_wsi_extension, | ||
| void* platform_specific_wsi_data); |
There was a problem hiding this comment.
you could just initialize this here to = nullptr and remove the changes to application.cpp line 61, and the last bit of desktop_main.cpp line 156.
|
What problem does this PR solve? That is to say, what is the symptom that this fixes? Thanks! |
|
@bradgrantham-lunarg Typically, capture an application that renders to a headless surface and try to replay it on Android. The first bug will cause |
This commit fixes 3 bugs:
VK_EXT_HEADLESS_SURFACE_EXTENSION_NAMEmissing inkSurfaceExtensionscli_wsi_extension_not being set (nor possible to set) when replaying on AndroidVK_KHR_surface